Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Phylogenetics #154

Open
2 of 5 tasks
sdhutchins opened this issue Jul 30, 2019 · 2 comments
Open
2 of 5 tasks

Refactor Phylogenetics #154

sdhutchins opened this issue Jul 30, 2019 · 2 comments
Assignees
@sdhutchins
Labels
Code Style Improvement 📈 🚧 Status: In Progress 🚧 Type: Maintenance 🔧
Milestone
Stable release v0.1

Comments

@sdhutchins
Copy link
Member

sdhutchins commented Jul 30, 2019 •
edited
Loading

What are you trying to accomplish?

Improve the Phylogenetics API and code style.

What is the error or issue?

The code is not using a number of Python's best practices.

TODO
  • Refactor ETE3PAML
  • Refactor PhyML
  • Remove pexpect from Phylip in favor of subprocess Refactor Phylip
  • Consider deprecating PhyloTree
  • Refactor CodemlRun
@sdhutchins sdhutchins self-assigned this Jul 30, 2019
@sdhutchins
Copy link
Member Author

@grabear I think I can have this done by Friday - I know we were wanting to do documentation after you got #152 done, but I feel confident I can knock this out close that point.

@sdhutchins sdhutchins pinned this issue Jul 31, 2019
@sdhutchins sdhutchins added this to the Stable release v0.1 milestone Jul 31, 2019
@sdhutchins sdhutchins unpinned this issue Jun 28, 2020
@sdhutchins
Copy link
Member Author

Will work on this over the weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdhutchins sdhutchins

Labels
Code Style Improvement 📈 🚧 Status: In Progress 🚧 Type: Maintenance 🔧
Projects
None yet
Milestone
Stable release v0.1
Development

No branches or pull requests
1 participant
@sdhutchins