Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Namespace CSS #4

Open
curran opened this issue Oct 26, 2018 · 0 comments
Open

Namespace CSS #4

curran opened this issue Oct 26, 2018 · 0 comments

Comments

@curran
Copy link
Member

curran commented Oct 26, 2018

Currently the CSS applies to any and all .Codemirror instances on the page.

It may be a good idea to namespace the CSS rules within something like .cm-s-ubuntu as in https://github.com/datavis-tech/vizhub-ui/blob/master/src/css/codemirror-ubuntu-theme.scss

This is how CodeMirror v5 themes are expected to be organized.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@curran