Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relational Connections: Inherit from Base Schema Rather Than Duplicating #286

Open
spicy-sauce opened this issue Apr 3, 2023 · 0 comments

Comments

@spicy-sauce
Copy link
Member

From Oren:

I merged it, although the more elegant solution would be to have the schema inherit from some base schema since we just duplicate those query and connect_args for each single connector.

It would be great to refactor the code to use inheritance from a base schema instead of duplicating query and connect_args for each individual connector. This would result in a more elegant and maintainable solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant