Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[question] NaN check for optimization algorithms? #1607

Open
Red-Portal opened this issue Dec 28, 2018 · 1 comment
Open

[question] NaN check for optimization algorithms? #1607

Red-Portal opened this issue Dec 28, 2018 · 1 comment
Labels

Comments

@Red-Portal
Copy link

Red-Portal commented Dec 28, 2018

I found out after painful debugging that dlib's find_global_min fails with a segmentation fault when the observed values contain NaN.
What do you think about including a NaN checking procedure to optimization algorithms?
If you like the idea I'll work on it and commit to dlib.

@Red-Portal Red-Portal changed the title [request] NaN check for optimization algorithms? [question] NaN check for optimization algorithms? Dec 28, 2018
@davisking
Copy link
Owner

It certainly shouldn't segfault. So yeah, if you want to submit a PR that makes it throw dlib::error or puts a DLIB_CASSERT on this then that would be a good addition.

@davisking davisking added the bug label Dec 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants