Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Private var needs to be public #532

Open
polycode-nz opened this issue Jun 6, 2019 · 5 comments
Open

Private var needs to be public #532

polycode-nz opened this issue Jun 6, 2019 · 5 comments

Comments

@polycode-nz
Copy link

Fuel_router has a private var $located that MX_Router has as public which results in a fatal error.

Changed to a public and seems to work.
@daylightstudio
Copy link
Owner

I'm not seeing that issue. What version of FUEL are you using?

@polycode-nz
Copy link
Author

polycode-nz commented Jun 6, 2019 via email •
edited
Loading

@daylightstudio
Copy link
Owner

What version of PHP are you using?

@polycode-nz
Copy link
Author

Turns out this server is old. PHP 5.5.9

@daylightstudio
Copy link
Owner

daylightstudio commented Jun 6, 2019 •
edited
Loading

Hmm... I don't have that specific version but do have a 5.5.38 and 5.6.37 and can't replicate that issue. If you simply comment out line 67 in the Fuel_router.php file (fuel/modules/fuel/core/Router.php), does that also fix the issue? That property exists in the parent class already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@daylightstudio @polycode-nz