Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid accidental @-mentions in transcripts #52

Open
AmeliaBR opened this issue Apr 22, 2020 · 6 comments
Open

Avoid accidental @-mentions in transcripts #52

AmeliaBR opened this issue Apr 22, 2020 · 6 comments

Comments

@AmeliaBR
Copy link
Contributor

AmeliaBR commented Apr 22, 2020

See w3c/csswg-drafts#4968 (comment) for an example of problems that this causes. (I've since edited that comment to break the mentions.)

Someone in the chat used an @ and the IRC nick of a group member, but on GitHub that nick belongs to an unrelated person who was annoyed by the sudden notification spam!

In the same chat, there were multiple instances of @ being used in the context of CSS rules (@ media and @ supports), and they were also getting automatically upgraded into GitHub mentions, although those seem to be unused accounts.

So, my suggestion would be to run a find & replace to insert a space or something after @ characters in the transcript.

@upsuper
Copy link
Contributor

upsuper commented Apr 22, 2020

Alternatively, we can wrap any @-mention with inline code (backtick) so that it's not upgraded, and we don't break the word with space.

@nigelmegitt
Copy link
Contributor

I use @ notation frequently as a deliberate way to mention people, and make sure to use their GitHub name not their IRC name, so disabling that would be a pain. I agree that it's no fun to have someone's IRC nick used as their GitHub name when it's someone different though!

I'd like something that's likely much more complex to implement, which is that @ notation followed by GitHub name is retained as now, but that some other notation is used to bring IRC nick's in and (this is the hard part) map it to their pre-registered GitHub name.

So say I'm nigel on IRC, and @nigelmegitt on GitHub, when scribing I might do something like:

.. and everyone really loved the excellent proposal from $nigel

and github-bot would replace $nigel with @nigelmegitt before posting the issue comment. This would also be super-handy when you can't remember someone's GitHub name, and mean that the scribe could use IRC-nick-based autocomplete, and the IRC log would match the list of those present.

I'm not sure if IRC nicks are registered anywhere though; I think probably not, so that would imply either some additional backend service is needed or at the start of each meeting an additional command would be needed per user, like:

github: nigel is @nigelmegitt 

and GitHub-bot would have to remember that for some period of time.

@dbaron
Copy link
Owner

dbaron commented Nov 3, 2022

Two comments here:

  • One of the tradeoffs here is that I've tried to make the bot's github comments be at least somewhat readable in their plain-text email form, although I admit it's not great. Some of the suggestions here might make things worse.
  • Second, the IRC log within the bot comments is within a markdown HTML block. Some of the suggestions here (backticks) don't work in markdown's HTML blocks. (It's entirely possible to have the contents of a <details> not be in markdown's HTML blocks -- it just requires blank lines -- and I did experiment with that in the early days of the bot -- but it would require redesigning a bunch of what the bot does today. In particular, the current design makes the escaping/sanitizing requirements for the bot substantially simpler than they would be if producing markdown outside of an HTML block.)

@dbaron
Copy link
Owner

dbaron commented Nov 3, 2022

Oh, and I think that replacing "@" with "@ " would be problematic because it would break people's syntax examples; it would be confusing to read a discussion about CSS at-rule syntax with such a substitution.

@Loirooriol
Copy link

Trick: insert <!----> after the @. Like this:

@Loirooriol

@dbaron
Copy link
Owner

dbaron commented Nov 3, 2022

Yeah, that's probably the least bad option (so far) that would fix this, though it shows up in plain text email, and some folks (see #52 (comment)) use this as a feature rather than a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants