-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.0, remove extra interfaces for registerCommand, leave one #439
Comments
Updates done and published new version of those in npm |
Thanks! |
@dbashford @aabenoja and I have moved off of mimosa. We would be open to a PR or adding you as a collaborator should you care to have our plugins updated. |
@dbashford I also moved off, I've done those updates but I also open an issue in the 3 repositories to look for maintainers and I added a note in READMEs which warn about it. |
@ifraixedes appreciate you making the updates, this sort of thing doesn't change often, so I don't expect much maintenance to be necessary going forward. I can fork and PR this particular change in a few minutes for those that remain. |
@dbashford no probs, I'll see in the future, however I wanted to warn to at least let people know that any issue or future enhancements are not going to be provided at least if nobody want to maintain them |
Ok for mimosa-s3-deployer (0.0.5). |
At this point all remaining libraries have PRs or are just awaiting an 3.0 is still at least a month away, so not a huge hurry, just providing a little ping to those that are left. Thanks! |
The execution of the
registerCommand
function has 2 signatures.Remove the 1st.
The
retrieveCallback
function passed toregisterCommand
has 3 different signatures.Remove the 1st/2nd.
The following command modules need updating, updating them now will not hurt anything since the remaining supported signatures have existed for awhile.
Quick example of a compliant
registerCommand
andretrieveConfig
module.The text was updated successfully, but these errors were encountered: