Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.0, remove extra interfaces for registerCommand, leave one #439

Open
16 of 18 tasks
dbashford opened this issue Mar 7, 2015 · 9 comments
Open
16 of 18 tasks

3.0, remove extra interfaces for registerCommand, leave one #439

dbashford opened this issue Mar 7, 2015 · 9 comments
Labels

Comments

@dbashford
Copy link
Owner

The execution of the registerCommand function has 2 signatures.

(program, retrieveConfig) deprecated
(program, logger, retrieveConfig)

Remove the 1st.

The retrieveCallback function passed to registerCommand has 3 different signatures.

(buildFirst, isDebug, callback), deprecated
(buildFirst, callback), deprecated
(opts, callback)

Remove the 1st/2nd.

The following command modules need updating, updating them now will not hurt anything since the remaining supported signatures have existed for awhile.

Quick example of a compliant registerCommand and retrieveConfig module.

  • mimosa-bower
  • mimosa-svgs-to-iconfonts
  • MimosaCoffeeModuleBare
  • mimosa-minify-img
  • mimosa-sprite
  • MimosaModuleJavaScriptSkeleton
  • mimosa-ember-test
  • mimosa-npm-web-dependencies
  • mimosa-volo
  • mimosa-testem-require
  • mimosa-fubumvc @mtscout6 @aabenoja
  • mimosa-spritesmith @ddlsmurf
  • mimosa-phantomcss @dbazile
  • mimosa-bless @mtscout6 @aabenoja
  • mimosa-asset-cache-bust @ifraixedes
  • mimosa-markdown @ifraixedes
  • mimosa-s3-deployer @Costent
  • mimosa-module-livescript-skeleton @ifraixedes
@ifraixedes
Copy link
Contributor

Updates done and published new version of those in npm

@dbashford
Copy link
Owner Author

Thanks!

@mtscout6
Copy link

@dbashford @aabenoja and I have moved off of mimosa. We would be open to a PR or adding you as a collaborator should you care to have our plugins updated.

@ifraixedes
Copy link
Contributor

@dbashford I also moved off, I've done those updates but I also open an issue in the 3 repositories to look for maintainers and I added a note in READMEs which warn about it.

@dbashford
Copy link
Owner Author

@ifraixedes appreciate you making the updates, this sort of thing doesn't change often, so I don't expect much maintenance to be necessary going forward.

I can fork and PR this particular change in a few minutes for those that remain.

@ifraixedes
Copy link
Contributor

@dbashford no probs, I'll see in the future, however I wanted to warn to at least let people know that any issue or future enhancements are not going to be provided at least if nobody want to maintain them

@willrnch
Copy link

Ok for mimosa-s3-deployer (0.0.5).

@dbashford
Copy link
Owner Author

@aabenoja @mtscout6 PRs sent to bless and fubu

@dbashford
Copy link
Owner Author

At this point all remaining libraries have PRs or are just awaiting an npm publish.

3.0 is still at least a month away, so not a huge hurry, just providing a little ping to those that are left. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants