Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PfkD-extended improvement: Optimize performance of pfkd-v2 #59

Open
4 tasks
dbdness opened this issue Apr 13, 2021 · 2 comments
Open
4 tasks

PfkD-extended improvement: Optimize performance of pfkd-v2 #59

dbdness opened this issue Apr 13, 2021 · 2 comments
Labels
enhancement New feature or request priority:high

Comments

@dbdness
Copy link
Owner

dbdness commented Apr 13, 2021

  • With the extension of pfkd-extended-id.sql (introduction of subqueries that output existing PK columns), the runtime performance has gotten significantly worse

  • The query should be optimized

  • Fix the duplicate subqueries that output the same results; find ways to run only once (temporary table, variable or alias'ed subquery etc.)

  • Lose the DISTINCT keywords and use appropriate GROUP BYs instead

  • Compare the new runtime with the old one

  • Consider creating issues for optimizing our other major queries as well

@dbdness dbdness added the enhancement New feature or request label Apr 13, 2021
@dbdness dbdness changed the title Optimize performance of pfkd-extended-id query PfkD-extended improvement: Optimize performance of pfkd-extended-id query Apr 13, 2021
@dbdness dbdness changed the title PfkD-extended improvement: Optimize performance of pfkd-extended-id query PfkD-extended improvement: Optimize performance of pfkd-v2 May 4, 2021
@dbdness
Copy link
Owner Author

dbdness commented May 6, 2021

Commit 9383b72 forbedrer performance med over 10 sekunder, blot ved at fjerne overflødige JOINs i pkd-subqueries, men jeg tænker der stadig er flere forbedringer at hente.

@dbdness
Copy link
Owner Author

dbdness commented May 7, 2021

Commit 48c5e9d forbedrer performance med yderligere 1 sekund, også ved at fjerne flere overflødige JOINs, hvilket bringer pfkd-v2 query builder execution ned på ~0.244 sekunder.

@dbdness dbdness added this to the Sprint 10 milestone May 21, 2021
@dbdness dbdness removed this from the Sprint 10 milestone May 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority:high
Projects
None yet
Development

No branches or pull requests

1 participant