Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show how to close multiple issues in the pull request template #153

Open
dbeatty10 opened this issue Jun 11, 2023 · 0 comments
Open

Show how to close multiple issues in the pull request template #153

dbeatty10 opened this issue Jun 11, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@dbeatty10
Copy link
Owner

❌ Easy mistake

GitHub has a nice feature:

When you merge a linked pull request into the default branch of a repository, its linked issue is automatically closed. For more information about the default branch, see "Changing the default branch."

But the syntax I've most often seen people try to use is like:

Resolves #10 #123 octo-org/octo-repo#100

In that case, only the 1st issue is linked and automatically closed; the other two will not be linked and will not be closed.

✅ Solution

Many contributors don't realize the syntax required by GitHub to close multiple requests at the same time:

Resolves #10, resolves #123, resolves octo-org/octo-repo#100

This is the way to go!

💡 Proposed feature

If the example in the pull request template shows how to close multiple issues, it increases the chances people will see it and use it.

@dbeatty10 dbeatty10 added the enhancement New feature or request label Jun 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant