Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login bug #79

Open
dbosk opened this issue May 29, 2023 · 6 comments
Open

Login bug #79

dbosk opened this issue May 29, 2023 · 6 comments
Labels
bug Something isn't working

Comments

@dbosk
Copy link
Owner

dbosk commented May 29, 2023

On mån 29 maj 2023 13:25:23, Marcus Dicander wrote:

Hej.

Jag tänkte testa canvaslms lokalt på min jobbdator och möttes där av följande:

$ ls
$ canvaslms login
Traceback (most recent call last):
File "/home/dicander/.local/bin/canvaslms", line 8, in
sys.exit(main())
File "/home/dicander/.local/lib/python3.10/site-packages/canvaslms/cli/init.py",
line 90, in main
canvas = Canvas(hostname, token)
File "/home/dicander/.local/lib/python3.10/site-packages/canvasapi/canvas.py",
line 32, in init
if "api/v1" in base_url:
TypeError: argument of type 'NoneType' is not iterable
$

Har du några förslag på vad jag kan testa istället?

@dbosk dbosk added the bug Something isn't working label May 29, 2023
@dbosk
Copy link
Owner Author

dbosk commented May 29, 2023

Probably related to #76

@monperrus
Copy link
Contributor

I can login, with no error.

But then:

$ canvaslms courses
/home/martin/.local/bin/canvaslms: error: No hostname or token, run `canvaslms login`

as if the information put during canvas login are not saved

@dbosk
Copy link
Owner Author

dbosk commented Jun 1, 2023

Thanks @monperrus ! Found the bug, I had a typo in the code. See dc747f2.

@monperrus
Copy link
Contributor

monperrus commented Jun 1, 2023 via email

@dbosk
Copy link
Owner Author

dbosk commented Jun 1, 2023

Do you have CD such that the pypy version is already up-to-date?

I do it manually for now. I just run make publish to publish a new version on PyPI, build a new Docker image and push to Docker Hub, build the documented source and publish a new release on GH with the PDF attached.

But I would like to use GH Actions instead to get CD, but we'll see when I've had the time to look into it.

@dbosk
Copy link
Owner Author

dbosk commented Jun 1, 2023

such that the pypy version is already up-to-date?

But yes, it's already up-to-date!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants