Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow fire_event to optionally handle warn_or_error functionality #236

Open
1 task done
QMalcolm opened this issue Jan 15, 2025 · 0 comments · May be fixed by #237
Open
1 task done

Allow fire_event to optionally handle warn_or_error functionality #236

QMalcolm opened this issue Jan 15, 2025 · 0 comments · May be fixed by #237
Assignees

Comments

@QMalcolm
Copy link
Contributor

Housekeeping

  • I am a maintainer of dbt-common

Short description

Originally warn_error and warn_error_options was only meant to work with a subset of warnings/errors. However, it has come to be assumed, more often than not, that both flags work with all warnings/errors. As such, we want fire_event to begin handling warn_error and warn_error_options in an opt-in manner. We unfortunately can't just by default turn it on as that might break working dbt projects (i.e. doing so would be a major version bump). At some point in the future the default will be opt-in, and even later we'll likely remove the ability to opt out.

Acceptance criteria

  • fire_event handles warn_error and warn_error_options
  • the handling of warn_error and warn_error_options in fire_event is opt-in
  • warn_or_error should pass through to fire_event with opt-in

Suggested Tests

  • by default warn_or_error functionality doesn't run in fire_event without opt-in
  • warn_or_error functionality does run in fire_event with opt-in
  • old warn_or_error passes through to fire_event

Impact to Other Teams

N/A

Will backports be required?

No

Context

dbt-labs/dbt-core#11116

@QMalcolm QMalcolm self-assigned this Jan 15, 2025
@QMalcolm QMalcolm linked a pull request Jan 17, 2025 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant