Skip to content
This repository has been archived by the owner on May 11, 2023. It is now read-only.

Large futures cause clippy to be triggered on programs which use zbus::Connection::session() #340

Open
zeenix opened this issue Apr 20, 2023 · 1 comment

Comments

@zeenix
Copy link
Collaborator

zeenix commented Apr 20, 2023

In GitLab by @TTWNO on Apr 20, 2023, 23:48

On beta and nightly, the new clippy lint large futures gets triggered when attempting to use the session connection:

error: large future with a size of 21448 bytes
   --> src/accessibility_connection.rs:291:16
    |
291 |     let session = zbus::Connection::session().await?;
    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider `Box::pin` on it: `Box::pin(zbus::Connection::session())`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_futures

I'm not sure if this is really a problem worth fixing or not; I don't know how likely a stack overflow really is, but I thought it was worth mentioning.

You will need to use +nightly or +beta to see the lint.

@zeenix
Copy link
Collaborator Author

zeenix commented Apr 21, 2023

Thanks for filing this. I'm away at the moment. I'll try to look into it soon.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant