Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Drop Windows platform support #1246

Open
zeenix opened this issue Feb 4, 2025 · 3 comments
Open

RFC: Drop Windows platform support #1246

zeenix opened this issue Feb 4, 2025 · 3 comments
Labels
api break windows Issue is specific to Windows zbus Issues/PRs related to zbus crate
Milestone

Comments

@zeenix
Copy link
Contributor

zeenix commented Feb 4, 2025

Given that:

  • I've no Windows machine to test any changes to Windows code and rely purely on the CI machines.
  • I have 0 interest in Windows platform.
  • With any refactor of the base types, Windows-specific code requires changes.
  • Windows code being very low-level, requiring unsafe and dealing with strange APIs.
  • I have only known 1 person who needs zbus on Windows.
  • With 5.0 dropping DBUS_COOKIE_SHA1 auth breaking the Windows support.

I think we need to consider removing this support.

Having said that, I am not expecting a lot of changes in the future requiring changes to Windows code and would be more than willing to keep the support if #723 is fixed before the next API break (no timeline or intentions for that at the moment).

@zeenix zeenix added api break windows Issue is specific to Windows zbus Issues/PRs related to zbus crate labels Feb 4, 2025
@zeenix zeenix added this to the zbus-6.0 milestone Feb 4, 2025
@zeenix
Copy link
Contributor Author

zeenix commented Feb 4, 2025

CC @elmarco

@elmarco
Copy link
Contributor

elmarco commented Feb 4, 2025

Having a portable IPC & DBus is big plus. It allows qemu-rdp and qemu-display to work on Windows, ANONYMOUS works in that case. Please don't remove Windows support. It's one of the strong reason why I contributed to zbus in the first place and I keep using it. Removing SHA1 was already a big disappointment. I would rather have a fully compliant and portable zbus implementation rather than a strim-down version. So #723 isn't strictly required atm.

@zeenix
Copy link
Contributor Author

zeenix commented Feb 4, 2025

I would rather have a fully compliant and portable zbus implementation rather than a strim-down version

cookie auth is not at all useful for Unix and dbus-broker doesn't even implement it. I don't think dropping of cookie auth should be viewed as going against compliance. The spec does not require it. The only reason for it to exist these days is Windows. So one thing is for sure: cookie auth is not going to be coming back.

Please don't remove Windows support.

If I don't have to touch the Windows code much, I will not remove it. This includes the CI, which has in the past given me a lot of headache.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api break windows Issue is specific to Windows zbus Issues/PRs related to zbus crate
Projects
None yet
Development

No branches or pull requests

2 participants