Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stored wrong in Database #6

Open
u12206050 opened this issue May 15, 2020 · 4 comments
Open

Stored wrong in Database #6

u12206050 opened this issue May 15, 2020 · 4 comments
Labels
bug Something isn't working

Comments

@u12206050
Copy link

Using Nova v3

When saving a resource all the resource fields including the ones within the JSONWrapper are saved as json in the database in one column.

Expected: Only the fields within the wrapper should be saved in the json column.

@milewski milewski added the bug Something isn't working label May 15, 2020
@mennotempelaar
Copy link
Contributor

@u12206050 Can u check if the #8 fixed ur problem?

@ThisIsMyFavouriteJar
Copy link

ThisIsMyFavouriteJar commented Jul 1, 2020

I got the same error, it seems all fields, also those outside the JsonWrapper are saved to the json.

@mennotempelaar , could you clarify how exactly you fixed this? Which specific lines of code did you change?

@mennotempelaar
Copy link
Contributor

@AbetaNL You can see the changes to the code here: bae503f

When you update your composer package dcasia/nova-json-wrapper to version 0.1.6 it will get my changes. That way you won't have to change it yourself.

@ThisIsMyFavouriteJar
Copy link

@mennotempelaar , unfortunately this does not seem to fix the issue for me. I found another workaround, which does not require the use of this plugin though. Thank you very much for your effort though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants