Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: "X w" doesn't work as expected #105

Open
aksr opened this issue Oct 30, 2019 · 7 comments
Open

Bug: "X w" doesn't work as expected #105

aksr opened this issue Oct 30, 2019 · 7 comments

Comments

@aksr
Copy link

aksr commented Oct 30, 2019

  1. Open sam.
  2. Create (one or) two files via new from the RMB-menu.
  3. Give them names via f command, for example: f 1 f 2.
    (names should be only one letter or number)
  4. Execute X w.

After step 4., you'll get: ?no file name.

(p9p's sam works fine.)

Edit: It seems it is the name where the problem lies, names should be only one letter or number (e.g. f 1, f 2, f a...)

@aksr aksr changed the title "X w" doesn't work if Bug: "X w" doesn't work as expected Oct 30, 2019
@ckeen
Copy link
Contributor

ckeen commented Oct 30, 2019 via email

@aksr
Copy link
Author

aksr commented Oct 30, 2019

@ckeen: Latest (5893679).

@ckeen
Copy link
Contributor

ckeen commented Oct 30, 2019 via email

@aksr
Copy link
Author

aksr commented Oct 31, 2019

@ckeen: You're forgeting something, execute the steps carefully. (OS: Arch Linux)

Edit: It seems it is the name where the problem lies, the name should be only one letter or number, (e.g. f 1, f 2, f a...)!

@aksr
Copy link
Author

aksr commented Oct 31, 2019

@ckeen: Try it with this new info.
(I'm writing a new comment since I'm not sure if you saw the last one (after I edited it),
since you're responding via email.
)

@aksr
Copy link
Author

aksr commented Oct 31, 2019

In the file sam.c, function getname (line: 535), I changed return genstr.n-1 to return genstr.n, and it seems to work now. Not sure if anything else is broken, though.

I'll investigate further.

aksr added a commit to aksr/sam that referenced this issue Oct 31, 2019
@ckeen
Copy link
Contributor

ckeen commented Oct 31, 2019 via email

japanoise pushed a commit to japanoise/sam that referenced this issue Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants