Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl-N then Undo (Esc u Enter) moves cursor #8

Open
drj11 opened this issue Feb 22, 2023 · 1 comment
Open

Ctrl-N then Undo (Esc u Enter) moves cursor #8

drj11 opened this issue Feb 22, 2023 · 1 comment

Comments

@drj11
Copy link
Contributor

drj11 commented Feb 22, 2023

Undoing a join puts the cursor just before the split point (the end of the first line that participated in the join). Regardless of where the cursor was.

Again, i can't tell if this is faithful to AmigaDOS or not, but it seems wrong even if it is faithful. I suppose undo in general should either put the cursor back to where it was or not move it at all.

To reproduce:

  • put the cursor at the beginning of a sequence of two lines both of which have content;
  • join the lines with Ctrl-N (note, cursor still at beginning of line)
  • undo the join with Esc u Enter. BUG: cursor jumps to join point

I've no idea what should happen morally, but it seems that the most tine thing to do
would be to not move the cursor at all.

by the way, it did surprise me that Ctrl-N join did not put the cursor at the join point, but i suppose that's intentional.

@deadpixi
Copy link
Owner

ED has no undo once a line has been inserted/deleted/moved away from, so we’re free to choose the behavior here.

The non-motion of the cursor upon join is, IIRC, the behavior of ED. Now I gotta go check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants