Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On mobile, first tap on "Sheet" link doesn't do anything #2282

Open
jpd236 opened this issue Oct 1, 2024 · 1 comment · May be fixed by #2312
Open

On mobile, first tap on "Sheet" link doesn't do anything #2282

jpd236 opened this issue Oct 1, 2024 · 1 comment · May be fixed by #2312

Comments

@jpd236
Copy link
Contributor

jpd236 commented Oct 1, 2024

When using JR in a mobile browser, if you click on the "Sheet" link, it underlines it but doesn't actually show the sheet the first time. It does work the second time.
@ebroder
Copy link
Member

ebroder commented Oct 1, 2024

This sounds like a dup of #1963

jpd236 added a commit to jpd236/jolly-roger that referenced this issue Oct 22, 2024
@jpd236
Revert DeepLinks in favor of regular links.
263e200 
This component was originally added in 2017 to deep link to native
Sheets/Docs apps when installed on mobile devices. On reasonably modern
devices, regular HTTP links should be intercepted by native apps when
present, so no special machinery is needed.

Fixes deathandmayhem#1963
Fixes deathandmayhem#2282
jpd236 added a commit to jpd236/jolly-roger that referenced this issue Oct 22, 2024
@jpd236
Revert DeepLinks in favor of regular links.
a5bac0c 
This component was originally added in 2017 to deep link to native
Sheets/Docs apps when installed on mobile devices. On reasonably modern
devices, regular HTTP links should be intercepted by native apps when
present, so no special machinery is needed.

Fixes deathandmayhem#1963
Fixes deathandmayhem#2282
@jpd236 jpd236 linked a pull request Oct 22, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert DeepLinks in favor of regular links. jpd236/jolly-roger
2 participants
@ebroder @jpd236