Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRY Implementation #117

Open
ChrisCates opened this issue Sep 22, 2019 · 1 comment
Open

DRY Implementation #117

ChrisCates opened this issue Sep 22, 2019 · 1 comment

Comments

@ChrisCates
Copy link

Description

As it stands. A lot of code is rewritten in each folder. Each separate chain has its own module and checksums, but, we could have the commands be refactored into separate folders and the modules for each chain are used instead.

Example

Main source code is in.

src/initiate.go
src/participate.go
# etc...

Chain specific source code is in

btc/go.mod
btc/sum.mod
btc/btcatomicswap.go

And so forth.

Suggestions

  • Refactor source code in this way in order to reduce SLOC and make it easier to review code.

  • Ensure that standards are consistent across all chains.

  • Ensure that test cases and documentation for each chain works properly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ChrisCates and others