Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 296 #297

Closed
wants to merge 4 commits into from
Closed

Fix 296 #297

wants to merge 4 commits into from

Conversation

amcadmus
Copy link
Member

No description provided.

@amcadmus amcadmus requested a review from njzjz May 26, 2022 13:14
@amcadmus amcadmus changed the base branch from master to devel May 26, 2022 13:14
@codecov-commenter
Copy link

codecov-commenter commented May 26, 2022 •
edited
Loading

Codecov Report

Merging #297 (016c48d) into devel (5c4008d) will increase coverage by 0.13%.
The diff coverage is 90.90%.

@@            Coverage Diff             @@
##            devel     #297      +/-   ##
==========================================
+ Coverage   81.57%   81.71%   +0.13%     
==========================================
  Files          62       62              
  Lines        5244     5262      +18     
==========================================
+ Hits         4278     4300      +22     
+ Misses        966      962       -4
Impacted Files Coverage Δ
dpdata/qe/traj.py 89.37% <90.90%> (+4.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c4008d...016c48d. Read the comment docs.

@njzjz njzjz linked an issue May 26, 2022 that may be closed by this pull request
[BUG] Read qe/cp/traj with unit angstrom without .cel file #296
Open
njzjz
njzjz requested changes May 26, 2022
View reviewed changes
dpdata/qe/traj.py Outdated Show resolved Hide resolved
@wanghan-iapcm
Copy link
Contributor

wanghan-iapcm commented May 27, 2022 •
edited
Loading

Now the UTs should have covered all cases. @njzjz

@wanghan-iapcm wanghan-iapcm requested a review from njzjz May 27, 2022 00:55
@amcadmus amcadmus closed this Jun 11, 2022
@amcadmus amcadmus deleted the fix-296 branch June 11, 2022 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njzjz njzjz njzjz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Read qe/cp/traj with unit angstrom without .cel file
4 participants
@amcadmus @codecov-commenter @wanghan-iapcm @njzjz