Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding StringJoiner #8357

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

feat: Adding StringJoiner #8357

wants to merge 10 commits into from

Conversation

sjrl
Copy link
Contributor

@sjrl sjrl commented Sep 12, 2024

Related Issues

Proposed Changes:

How did you test it?

Notes for the reviewer

Checklist

@coveralls
Copy link
Collaborator

coveralls commented Sep 17, 2024

Pull Request Test Coverage Report for Build 11272302381

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 90.342%

Totals Coverage Status
Change from base Build 11235547007: 0.01%
Covered Lines: 7474
Relevant Lines: 8273

💛 - Coveralls

@sjrl
Copy link
Contributor Author

sjrl commented Sep 26, 2024

Hey @silvanocerza this is one of the PR's that contains a pipeline behavioral test that fails currently but works in your subgraphs branch.

@sjrl
Copy link
Contributor Author

sjrl commented Oct 10, 2024

Once this PR #8431 is merged then the component in this PR will work and be ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic:tests type:documentation Improvements on the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Add StringJoiner as a convenience component
2 participants