Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag for setting configuration variables #647

Open
1 task
brandtkeller opened this issue Sep 8, 2024 · 2 comments
Open
1 task

Flag for setting configuration variables #647

brandtkeller opened this issue Sep 8, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@brandtkeller
Copy link
Member

Is your feature request related to a problem? Please describe.

Ability to set a configuration variable from the command line through the use of a flag.

Describe the solution you'd like

  • Given a flag for setting variables
  • When a command is executed with a flag and a key/value pair
  • Then that key/value pair is merged with other configuration data

Describe alternatives you've considered

Only allow setting the configuration through the configuration file

Additional context

We will need the ability to set a configuration item as sensitive in some way.

This could be multiple flags --variable --secret

Expected Deliverable

  • add flag support to all commands that will template a file during some process
@brandtkeller brandtkeller added the enhancement New feature or request label Sep 8, 2024
@github-actions github-actions bot added the triage Awaiting triage from the team label Sep 8, 2024
@brandtkeller brandtkeller removed the triage Awaiting triage from the team label Sep 9, 2024
@meganwolf0
Copy link
Collaborator

Just saw this - I think in #672 I have made kind of an opinionated stance on this, at least with respect to the lula tools template command. Where in this command those template value are --set .path.to.key=val, and the .path.to.key would really be whatever the template value is expecting (so right now supports .const.whatever and .var.whatever). Obviously this could also be a different mechanism for other commands where templates are introduced (e.g., compose or validate). But perhaps this issue is closed if we implement on #641 and other commands' specific implementations could/should be tied to implementing templating in those?

@brandtkeller
Copy link
Member Author

Agreed - the scope of #641 should provide for the structure of sensitive configurations and those configurations generically.

The remaining issues (and any that need be created) in the milestone should be to implement a pattern across all commands for implementing templating and any supported flag implementations that establish parity for the ability to set configuration in env avrs, config file, command line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 🔖 Ready
Development

No branches or pull requests

2 participants