Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validation Review Fields/Process #460

Open
brandtkeller opened this issue Jun 3, 2024 · 2 comments · May be fixed by #667
Open

Validation Review Fields/Process #460

brandtkeller opened this issue Jun 3, 2024 · 2 comments · May be fixed by #667
Assignees
@meganwolf0
Labels
enhancement New feature or request
Milestone
Aligned Capabilities

Comments

@brandtkeller
Copy link
Member

Is your feature request related to a problem? Please describe.

Capture processes and enhancements to the validation process for how a validation is/should be tested.

Describe the solution you'd like

  • Given a decomposed validation exists
  • When dev validate is executed
  • Then context and processes are present to test pass/fail scenarios

Describe alternatives you've considered

Perform this as an isolated process from Lula

Additional context

This could be additional fields in the validation that support how to test the validation.

Should we trim these off when composing?
@brandtkeller brandtkeller added the enhancement New feature or request label Jun 3, 2024
@github-actions github-actions bot added the triage Awaiting triage from the team label Jun 3, 2024
@meganwolf0 meganwolf0 linked a pull request Sep 16, 2024 that will close this issue
Open
6 tasks
@meganwolf0 meganwolf0 removed the triage Awaiting triage from the team label Sep 17, 2024
@meganwolf0
Copy link
Collaborator

Initial cut at solution in #667 - still missing some functionality but I think the doc highlights where it's going
Took the stance that tests should exist in the validation, so I think the composed/decomposed conversation is possibly moot with that implementation. As to whether those should be trimmed... I could possibly see a case for wanting to re-test the validation on the actual resources in the environment to ensure it's continually relevant? I'm thinking maybe for more of the long-lived system/continual evaluation piece

@brandtkeller
Copy link
Member Author

Discussion - create a design doc

@meganwolf0 meganwolf0 self-assigned this Oct 18, 2024
@brandtkeller brandtkeller added this to the Aligned Capabilities milestone Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meganwolf0 meganwolf0

Labels
enhancement New feature or request
Projects
Lula and Friends
Status: 👀 In Review
Milestone
Aligned Capabilities
Development

Successfully merging a pull request may close this issue.

feat(validation)!: validation testing framework defenseunicorns/lula
2 participants
@brandtkeller @meganwolf0