Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide meaningful unit tests for src/lib/controller/index.ts #1521

Open
samayer12 opened this issue Dec 5, 2024 · 0 comments
Open

Provide meaningful unit tests for src/lib/controller/index.ts #1521

samayer12 opened this issue Dec 5, 2024 · 0 comments

Comments

@samayer12
Copy link
Collaborator

Describe what should be investigated or refactored

index.ts exposes a constructor suffers from poor test-coverage. There are several instances of branching logic in that file that need test coverage.

Create some unit tests that execute some of the varying paths through src/lib/controller/index.ts and make meaningful assertions to aid someone who is digging into future issues with a Journey or E2E test. We'll know we're "done" with this when CodeCov reports a better coverage (say, 60% or greater?) percentage and the corresponding unit tests make meaningful assertions.

Links to any relevant code

Additional context

We noticed a need for better testing in this file as part of #1519.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🆕 New
Development

No branches or pull requests

1 participant