Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Codeowners #60

Open
chaospuppy opened this issue Jul 26, 2024 · 1 comment
Open

Add Codeowners #60

chaospuppy opened this issue Jul 26, 2024 · 1 comment

Comments

@chaospuppy
Copy link
Contributor

@mjnagel:

Might be worth setting up codeowners here for some of the subdirectories. In particular might be something like:

packer/vsphere: owned by @chaospuppy n company (@defenseunicorns/mission-ops-team ?)
packer/nutanix: owned by @jacobbmay n company (@defenseunicorns/digital-salmon ?)
all other files: owned by @defenseunicorns/uds-core
Given the current limited ability to CI test vsphere/nutanix it's probably good to have those owned by teams that have access to > test environments. Also could adjust CI accordingly so that the AWS CI isn't required when only vsphere/nutanix changes are present.

@mjnagel
Copy link
Collaborator

mjnagel commented Jul 26, 2024

I believe the settings are in place for branch protection to ensure codeowner review is required but would be good to validate that once codeowners are in place as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants