Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve testing for dockerbuilder #88

Closed
smothiki opened this issue Aug 10, 2016 · 2 comments
Closed

Improve testing for dockerbuilder #88

smothiki opened this issue Aug 10, 2016 · 2 comments
Labels
enhancement help wanted needs tests

Comments

@smothiki
Copy link
Contributor

As of now dockerbuilder is a part of full E2E test. But if we look at functionality here dockerbuilder only does two things in DEIS. Takes a tar file extracts the code, builds a docker container according to the Dockerfile and pushes the container to registry.
Any PR in dockerbuilder should or also do this test instead of running entire E2E suite.

refer deis/workflow-e2e#303
@smothiki smothiki self-assigned this Aug 10, 2016
@bacongobbler
Copy link
Member

related #36

@bacongobbler
Copy link
Member

closing as a duplicate of #36.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted needs tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bacongobbler @smothiki