-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(healthchecks): add deis healthchecks e2e tests #247
Conversation
62c95a5
to
5aec633
Compare
. "github.com/onsi/gomega/gexec" | ||
) | ||
|
||
var _ = Describe("deis config:healthchecks", func() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you change this to just "deis healthchecks"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
also needs a commit squash before merge since there's a merge commit in here |
5aec633
to
f72046e
Compare
f72046e
to
7903ae0
Compare
@bacongobbler can you check now again? |
}) | ||
|
||
// disable httpGet liveness checks as it won't pass for every app | ||
// TODO(bacongobbler): somehow determine *what* port we need to set the liveness check for this app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe @bacongobbler created the following ticket for this TODO
-- can we reference the issue number here? #245
both comments purely around |
Commits still need squashing here. |
closes #245