feat(healthchecks): add deis healthchecks e2e tests #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmala
force-pushed
the
bacongobbler-deis-healthchecks
branch
from
62c95a5
to
5aec633
Compare
| . "github.com/onsi/gomega/gexec" | ||
| ) | ||
|
|
||
| var _ = Describe("deis config:healthchecks", func() { |
There was a problem hiding this comment.
can you change this to just "deis healthchecks"?
|
also needs a commit squash before merge since there's a merge commit in here |
kmala
force-pushed
the
bacongobbler-deis-healthchecks
branch
from
5aec633
to
f72046e
Compare
kmala
force-pushed
the
bacongobbler-deis-healthchecks
branch
from
f72046e
to
7903ae0
Compare
|
@bacongobbler can you check now again? |
| }) | ||
|
|
||
| // disable httpGet liveness checks as it won't pass for every app | ||
| // TODO(bacongobbler): somehow determine *what* port we need to set the liveness check for this app |
There was a problem hiding this comment.
I believe @bacongobbler created the following ticket for this TODO -- can we reference the issue number here? #245
|
both comments purely around |
|
Commits still need squashing here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #245