Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added missing sections to most visuals, and added missing visual templates #65

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added missing sections to most visuals, and added missing visual templates #65

wants to merge 2 commits into from

Conversation

MattRudy
Copy link
Contributor

I tested all of the following theme improvements using the April 2021 release.

Added new sections to the following visuals:

Added the following visuals:

@MattRudy
Copy link
Contributor Author

@MikeCarlo - These issues should all close once David merges the PR back.

@DMiradakis
Copy link

@MattRudy thanks for making this pull request. Hopefully the author accepts it soon.

@shawnfactorial
Copy link

@MattRudy Nice work! How did you determine the JSON visual names for each of these visuals you added, like esriVisual? I ask because I'd like to add the Text Filter custom visual to my theme, if it's possible.

This was referenced Oct 13, 2021
Open
Open
@MattRudy
Copy link
Contributor Author

This PR has now been merged in the new Repository https://github.com/MattRudy/PowerBI-ThemeTemplates
@DMiradakis - please follow the new repository for more details.
@shawnfactorial - Create an issue for the Text Filter visual in the new repository! You can figure these out by looking at the underlying layout files behind a Power BI report - I'll add a section to the new repository about how to do this so you and others can do it on your own when needed.

@MattRudy MattRudy mentioned this pull request Oct 15, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@MattRudy @DMiradakis @shawnfactorial