Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignored exceptions #4

Open
felixwiemuth opened this issue Sep 20, 2017 · 1 comment
Open

Ignored exceptions #4

felixwiemuth opened this issue Sep 20, 2017 · 1 comment
Labels

Comments

@felixwiemuth
Copy link

You are ignoring all exceptions in Source/library/src/main/java/im/delight/android/languages/Language.java. This is bad practice, if you don't expect exceptions, just rethrow all exceptions as RuntimeException but don't ignore them.

@ocram ocram added the bug label Sep 21, 2017
@ocram
Copy link
Contributor

ocram commented Sep 21, 2017

You're right, thanks!

That must be this line:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants