Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix module logic once drgn supports library and module lookup. #74

Open
pcd1193182 opened this issue Mar 20, 2023 · 0 comments
Open

Fix module logic once drgn supports library and module lookup. #74

pcd1193182 opened this issue Mar 20, 2023 · 0 comments

Comments

@pcd1193182
Copy link
Contributor

pcd1193182 commented Mar 20, 2023

The modules PR includes the syntax to specify that certain commands should only be included if certain modules or libraries are loaded. This syntax is being added speculatively, becuase we do not yet have the ability to query the list of loaded modules or libraries. Once that functionality is present in drgn, we need to retool the logic of the modules PR to properly decide which commands to include. This should not be especially difficult; simply changing the logic in register_commands should suffice.

We can also clean up some small changes that were made to prevent crashes due to non-present types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant