allow to set tags on profiles #3373
Conversation
adbenitez
added
the
enhancement
|
this uses |
|
nice! indeed i also drafted sth. these days, see deltachat/deltachat-core-rust#6088 and main...r10s/internal-profile-names while the android PR is far behind yours (maybe only some inspiration for wordings), we should consider to add an "official" config for core - i think, it makes sense to sync them at some point and also that is better wrt compatibility. might also be, core will use the labels for sth at some point, name of backups or so |
|
To test the changes in this pull request, install this apk: |
src/main/java/org/thoughtcrime/securesms/accounts/AccountSelectionListFragment.java
Outdated
Show resolved
Hide resolved
|
To test the changes in this pull request, install this apk: |
this PR allows setting a "private tag" for a profile, see deltachat/deltachat-android#3373 for a possible UI. currently, the core does not do anything with the tag (so, it could also be a ui.-config option), however, this may change in the future - it might bet synced, and become also otherwise useful in core. also, having this in core is better documentation-wise, as otherwise each UI easily does its own things :)
|
updated to use the new |
|
To test the changes in this pull request, install this apk: |
|
updated the core on main; this PR needs a rebase |
adbenitez
force-pushed
the
adb/tag-profiles
branch
from
9343514
to
a2141df
Compare
|
To test the changes in this pull request, install this apk: |
Co-authored-by: bjoern <[email protected]>
|
To test the changes in this pull request, install this apk: |
| android:id="@+id/addr_or_tag" | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:textDirection="ltr" |
There was a problem hiding this comment.
@r10s just realized that this might be problematic with rtl languages tags, removed it, but in my tests there is no difference with/without with addresses or Arabic text
There was a problem hiding this comment.
this might come from copy+paste from old signal code, where this was a phone number ...
good to remove it.
see https://support.delta.chat/t/chat-folders-to-collect-chats-by-context/2201