Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking notifications in the actions center (Windows) does nothing #4414

Open
WofWca opened this issue Dec 17, 2024 · 7 comments
Open

Clicking notifications in the actions center (Windows) does nothing #4414

WofWca opened this issue Dec 17, 2024 · 7 comments
Labels
bug Something isn't working OS: Linux OS: Windows This issue or PR is related to Windows OS

Comments

@WofWca
Copy link
Collaborator

WofWca commented Dec 17, 2024

  • Operating System (Linux/Mac/Windows/iOS/Android): Windows 10
  • Delta Chat Version: 1.48.0
  • Expected behavior: Clicking a notification opens the corresponding chat and focuses the Delta Chat window.
  • Actual behavior: The notification simply gets hidden and nothing else happens.
  • Steps to reproduce the problem:
    1. Receive a message. You will get a notification.
    2. Wait for the notification to disappear from the screen, and slide to the Actions Center
    3. Open the Actions Center
    4. Click on the notification
  • Screenshots:
  • Logs:

Here is where the click handler is defined:

notify.on('click', Event => {
onClickNotification(data.accountId, chatId, data.messageId, Event)
notifications[chatId] =
notifications[chatId]?.filter(n => n !== notify) || []
notify.close()
})

I did some search, but couldn't find a simple solution:

It seems like the issue affects other Electron apps, e.g. Element.

I opened a similar issue before: #3982, but it was a bit too broad.
Another similar, but probably different issue: #2438 (there it's about previous session, whereas in this issue the session is never terminated).


Maybe it's not worth to work on this since we're migrating to Tauri.

@WofWca WofWca added bug Something isn't working OS: Windows This issue or PR is related to Windows OS labels Dec 17, 2024
@nicodh
Copy link
Contributor

nicodh commented Dec 17, 2024

I have the same behaviour on Linux but even Thunderbird, Signal & Slack notifications do not react on click in the notification center (Budgie Desktop)
On Mac it works as expected

@nicodh
Copy link
Contributor

nicodh commented Jan 10, 2025

To me this looks like an Electron issue which can't be solved by us, so I propose to move this to Project Resurrection https://github.com/orgs/deltachat/projects/75

@Simon-Laux
Copy link
Member

Well there is no guarantee that we will really move to tauri, and it is a bug for a fundamental feature, so I wouldn't move it to resurrection (because that's more for like feature requests)

@nicodh
Copy link
Contributor

nicodh commented Jan 10, 2025

But what chance do we have to fix it, if it's an Electron issue? On freshly showing up notification the click works. I have the same on Linux as mentioned above, so it's obviously an OS related issue.

So this bug will stay until Electron fixes it or forever if it is not fixed

@Simon-Laux
Copy link
Member

If there a link to the electron issue, then we can wait for it to be fixed then update electron.
If there is no electron issue to link yet, we need to create a minimal reproducible example and file the issue. ( the issues wofwca mentioned are all closed).

Other option would be to create notifications directly on affected platforms, but may be not important enough to us.

@nicodh
Copy link
Contributor

nicodh commented Jan 10, 2025

the issues wofwca mentioned are all closed

electron/electron#29461 exists since 2021, last report is from last month - status is "not planned" so what are we waiting for?

For me a typical case to move to "longtime backlog" what is Project Resurrection for me

@Simon-Laux
Copy link
Member

status is "not planned" so what are we waiting for?

not marked by a human, but by a stale bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working OS: Linux OS: Windows This issue or PR is related to Windows OS
Projects
None yet
Development

No branches or pull requests

3 participants