-
-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve backup transfer dialog. #4476
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, just to be clear, this relies on the core to show the progress of 0 when we're not connected.
The linter is complaining. Otherwise looks good!
packages/frontend/src/components/dialogs/SetupMultiDevice/ReceiveBackupProgressDialog.tsx
Outdated
Show resolved
Hide resolved
packages/frontend/src/components/dialogs/SetupMultiDevice/ReceiveBackupProgressDialog.tsx
Outdated
Show resolved
Hide resolved
by definition, 0 means "error, cannot connect, aborting", at least on rust/cffi event level: changing that to another meaning or having different meanings between cffi and jsonrpc here is a call for trouble. android also shows "connecting", but does that only before the first event is emitted. android also shows a hint "since forever", we can think over rewording (eg. pointing to troubleshooting, that was not always available). so maybe a better and easier approach for desktops is to do the same:
that way, we also do not need to think about what is "slower than expected" - and we can maintain the same wording across all platforms this is how android looks like: |
add description of the current step (connecting devices or transfering), button for trouble shooting and after 4 seconds of progress = 0 it shows a message telling the user to checkout trouble shooting closes #4420
8d5f92b
to
39bf194
Compare
Co-authored-by: iequidoo <[email protected]> Co-authored-by: bjoern <[email protected]>
Good Point, we should use some different value for the connection step then if needed. Or change the logic in desktop to wait for first update. On desktop it does not rely on the error in the progress report event, it just displays the error |
Just in case i've checked that the core only reports 0 on errors or a canceled transfer. |
closes #4420