Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve backup transfer dialog. #4476

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Simon-Laux
Copy link
Member

@Simon-Laux Simon-Laux commented Jan 11, 2025

Bildschirmfoto 2025-01-11 um 02 15 10 Bildschirmfoto 2025-01-11 um 21 22 50 Bildschirmfoto 2025-01-11 um 02 17 43
  • add description of the current step (connecting devices or transfering)
  • button for trouble shooting
  • and after 4 seconds of progress = 0 it shows a message telling the user to checkout trouble shooting

closes #4420

Copy link
Collaborator

@WofWca WofWca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, just to be clear, this relies on the core to show the progress of 0 when we're not connected.

The linter is complaining. Otherwise looks good!

_locales/_untranslated_en.json Outdated Show resolved Hide resolved
@r10s
Copy link
Member

r10s commented Jan 11, 2025

So, just to be clear, this relies on the core to show the progress of 0 when we're not connected.

by definition, 0 means "error, cannot connect, aborting", at least on rust/cffi event level:

changing that to another meaning or having different meanings between cffi and jsonrpc here is a call for trouble.

android also shows "connecting", but does that only before the first event is emitted.

android also shows a hint "since forever", we can think over rewording (eg. pointing to troubleshooting, that was not always available).

so maybe a better and easier approach for desktops is to do the same:

  • as long as screen shows "Connecting..." show the unconditional hint multidevice_same_network_hint

that way, we also do not need to think about what is "slower than expected" - and we can maintain the same wording across all platforms

this is how android looks like:

CHANGELOG.md Outdated Show resolved Hide resolved
_locales/_untranslated_en.json Outdated Show resolved Hide resolved
_locales/_untranslated_en.json Outdated Show resolved Hide resolved
add description of the current step (connecting devices or transfering), button for trouble shooting and after 4 seconds of progress = 0 it shows a message telling the user to checkout trouble shooting

closes #4420
Co-authored-by: iequidoo <[email protected]>
Co-authored-by: bjoern <[email protected]>
@Simon-Laux
Copy link
Member Author

by definition, 0 means "error, cannot connect, aborting", at least on rust/cffi event level:

Good Point, we should use some different value for the connection step then if needed. Or change the logic in desktop to wait for first update.

On desktop it does not rely on the error in the progress report event, it just displays the error getBackup throws.

@iequidoo
Copy link

by definition, 0 means "error, cannot connect, aborting", at least on rust/cffi event level:

Just in case i've checked that the core only reports 0 on errors or a canceled transfer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

small improvements to backup transfer progress dialog
5 participants