Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dedicated error dialog when core executable is missing #4469

Closed
Simon-Laux opened this issue Jan 10, 2025 · 1 comment · Fixed by #4479
Closed

Add dedicated error dialog when core executable is missing #4469

Simon-Laux opened this issue Jan 10, 2025 · 1 comment · Fixed by #4479
Assignees
@Simon-Laux
Labels
good first issue Good for newcomers technical debt

Comments

@Simon-Laux
Copy link
Member

Sometimes antivirus software decided to delete core #4209

We should make an extra error dialog for this case to inform the user to look if they can restore it from some "quarantine" and report the issue to us. Also to help with avoiding blame for delta chat.
@Simon-Laux Simon-Laux changed the title Add Dedicated Error Dialog when core executable is missing Add dedicated error dialog when core executable is missing Jan 10, 2025
@Simon-Laux Simon-Laux added the good first issue Good for newcomers label Jan 10, 2025
@Simon-Laux Simon-Laux mentioned this issue Jan 10, 2025
Closed
@Simon-Laux Simon-Laux self-assigned this Jan 11, 2025
@link2xt link2xt mentioned this issue Jan 11, 2025
Open
Simon-Laux added a commit that referenced this issue Jan 11, 2025
@Simon-Laux
add special error dialog for the case that deltachat-rpc-server is no…
e66345b 
…t found

closes #4469
@Simon-Laux Simon-Laux mentioned this issue Jan 11, 2025
Merged
@WofWca
Copy link
Collaborator

WofWca commented Jan 18, 2025 •
edited
Loading

Markling as "blocker", as per deltachat/deltachat-core-rust#6338 (comment):

I will wait until the fix #4469 for desktop is merged, then merge deltachat/deltachat-core-rust#6348.

Edit: actually, the description says "blocking a new release", which is not the case here I suppose.

@WofWca WofWca added blocker This issue is blocking a new release and removed blocker This issue is blocking a new release labels Jan 18, 2025
nicodh pushed a commit that referenced this issue Jan 27, 2025
@Simon-Laux @nicodh
add special error dialog for the case that deltachat-rpc-server is no…
8cf5791 
…t found

closes #4469
nicodh pushed a commit that referenced this issue Jan 27, 2025
@Simon-Laux
error dialog is deltachat-rpc-server is not found (#4479)
c0fdab6 
closes #4469
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Simon-Laux Simon-Laux

Labels
good first issue Good for newcomers technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

error dialog is deltachat-rpc-server is not found deltachat/deltachat-desktop
2 participants
@Simon-Laux @WofWca