Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We still store lastAccount in desktop settings, is there a still reason why we don't use the selected_account from core's account manager? #4474

Open
Simon-Laux opened this issue Jan 10, 2025 · 0 comments

Comments

@Simon-Laux
Copy link
Member

Simon-Laux commented Jan 10, 2025

I think in the past we didn't do it because there isn't an unselect account api yet.

we already have select_account and get_selected_account_id, but at the moment they have todo comments to be removed because we don't use them.

While it is important that the jsonrpc api doesn't depend on the global selected account variable, I think it might make sense to use it to just store the last account. (to have less important state in the config.json / desktop settings file)

The actionable item is to find answer to the following questions:

  • what would be needed besides an additional method to remove selection (like is the state that no account is selected even possible
  • is what I'm proposing here even a good idea?
  • are there any side effects of using the core variable, like core depending on this variable for something or core automatically setting/reading this variable?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant