Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show number of unread messages in Back-button on ChatViewController #2280

Open
r10s opened this issue Aug 20, 2024 · 1 comment · May be fixed by #2303
Open

Show number of unread messages in Back-button on ChatViewController #2280

r10s opened this issue Aug 20, 2024 · 1 comment · May be fixed by #2303
Assignees
Labels
enhancement actually in development, user visible enhancement

Comments

@r10s
Copy link
Member

r10s commented Aug 20, 2024

... if > 0

when Alices chats in "Chat with Bob" for hours, and a new message arrives in "Chat with Claire", Alice won't be aware of Claire's messages until she goes back to the chatlist at some point.

on android, we solved this issue by showing the "normal" notifications in case a message arrives in a foreign chat while being in another chat. this probably requires to track the chat_id in-app (the "Notification Service Extension" (NSE) is not envolved when the app is in foreground iirc, but not sure) (ftr for the record: adding flags to completionHandler([.badge]) sounds promising)

these additional notification must not be shown when already being in the chatlist (we have the badge counters there) and are also not needed from inside the settings or other screens (either the badge counter abottom is visible - and, usually, one is not that often and for hours in these screens)

if this is not possible at all, an alternative is to show the unread-badges atop of the in-chat back-button

@r10s r10s added the enhancement actually in development, user visible enhancement label Aug 20, 2024
@zeitschlag
Copy link
Collaborator

If we'd show a TabBar-item indicator, we show the number of unread messages in the back-button of a chat

@zeitschlag zeitschlag changed the title add visible feedback if a message arrives in a different chat Show number of unread messages in Back-button on ChatViewController Sep 18, 2024
@zeitschlag zeitschlag self-assigned this Sep 20, 2024
zeitschlag added a commit that referenced this issue Sep 20, 2024
Consider this WIP as there's still some flickering when receiving a message when on a chat. Something, something event-handling
@zeitschlag zeitschlag linked a pull request Sep 20, 2024 that will close this issue
zeitschlag added a commit that referenced this issue Sep 20, 2024
Back-button wasn't updated when there were no more fresh messages
zeitschlag added a commit that referenced this issue Sep 23, 2024
zeitschlag added a commit that referenced this issue Oct 5, 2024
Consider this WIP as there's still some flickering when receiving a message when on a chat. Something, something event-handling
zeitschlag added a commit that referenced this issue Oct 5, 2024
Back-button wasn't updated when there were no more fresh messages
zeitschlag added a commit that referenced this issue Oct 5, 2024
r10s pushed a commit that referenced this issue Oct 15, 2024
Consider this WIP as there's still some flickering when receiving a message when on a chat. Something, something event-handling
r10s pushed a commit that referenced this issue Oct 15, 2024
Back-button wasn't updated when there were no more fresh messages
r10s pushed a commit that referenced this issue Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement actually in development, user visible enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants