Feat/add dynamic tolerations #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ales Verbic <[email protected]>
* chore: implemented crdgen json output * chore: implemented crdgen json output
bootstrap/proxy/service.tf
Outdated
| @@ -17,11 +19,51 @@ resource "kubernetes_service_v1" "proxy_service" { | |||
|
|
|||
| port { | |||
| name = "proxy" | |||
| port = 443 | |||
| port = 9443 | |||
There was a problem hiding this comment.
Is there a reason for changing the load balancer port and changing the protocol? this will work our existing infra as is I believe
There was a problem hiding this comment.
I was trying to remember if it was related to cert-manager, but I changed it back to 433 and HTTPS because I have no valuable reason
Signed-off-by: Ales Verbic <[email protected]>
verbotenj
force-pushed
the
feat/add-dynamic-tolerations
branch
from
4b4f9a0 to
64db91a
Compare
gonzalezzfelipe
approved these changes
Dec 18, 2024
|
Fell free to merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.