Introduce deduplication key #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennis-tra
force-pushed
the
deduplication-key
branch
8 times, most recently
from
d7d0d1a to
ef3206d
Compare
dennis-tra
force-pushed
the
deduplication-key
branch
from
a18cb9e to
7d0fcc1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the concept of deduplication keys.
A deduplication key is a unique string used for deduplication of crawl tasks. For example, in discv4 and discv5 we might want to crawl the same peer (as identified by its public key) multiple times when we find new ENR's for it. If the deduplication key was just the public key, we would only crawl it only once. If we later find newer ENR's for the same peer with different network addresses, we would skip that peer. On the other hand, if the deduplication key was the entire ENR, we would crawl the same peer with different (potentially newer) connectivity information again.