fix: don't wait for the identify exchange to complete before draining buckets #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennis-tra
force-pushed
the
parallel-drain
branch
from
81e0a94 to
1e77f4b
Compare
cortze
approved these changes
Oct 28, 2024
| @@ -29,6 +29,7 @@ var KnownErrors = map[string]string{ | |||
| "max dial attempts exceeded": models.NetErrorMaxDialAttemptsExceeded, | |||
| "host is down": models.NetErrorHostIsDown, | |||
| "stream reset": models.NetErrorStreamReset, | |||
| "stream closed": models.NetErrorStreamReset, | |||
There was a problem hiding this comment.
should we create a new models.NetErrorStreamClosed entry for this error?
(I'm not 100% sure if it just means the same as the "stream reset" one)
There was a problem hiding this comment.
yeah, I'm lazy and didn't want to add a migration just for this error code 🙈
It's not exactly the same as a stream reset but for analysis purposes I'd say we can treat it equally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
idle_connection_timeoutlibp2p/rust-libp2p#4912