Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using as a github Action uploads all files without exclusion option #181

Closed
mcandeia opened this issue Oct 26, 2023 · 2 comments · Fixed by #135
Closed

Using as a github Action uploads all files without exclusion option #181

mcandeia opened this issue Oct 26, 2023 · 2 comments · Fixed by #135

Comments

@mcandeia
Copy link

Description

I am currently using a GitHub Action in my project, and I've noticed an issue where the action is uploading all files in my directory without providing an option to exclude specific files or directories. While the underlying command-line tool used by the GitHub Action supports an "exclude" option, the Action itself seems to reject this option as invalid. (check the screenshow at the end)

My project contains fewer than 100 files, but according to the Action's logs, it is attempting to upload over 9,000 files, resulting in a total size of 51MB. Also I noticed that the Deno stops to receive my files due to an arbitrary timeout.

Expected Behavior:

I would expect the GitHub Action to provide a way to exclude specific files or directories from the upload process, as is supported by the underlying command-line tool. This would allow for more precise control over what gets uploaded and reduce unnecessary load on the workflow.

Github Action Run example: https://github.com/deco-sites/candy-nodemod/actions/runs/6655099986/job/18084591799
image

@mcandeia mcandeia changed the title Using as a gitHub Action uploads all files without exclusion option Using as a github Action uploads all files without exclusion option Oct 26, 2023
@mcandeia
Copy link
Author

Sorry, I forgot to mention that I'm using deployctl as a composite action here: https://github.com/deco-cx/deploy/blob/main/action.yaml#L50

@arnauorriols
Copy link
Member

Hey, thanks for the detailed report! Just for your reference, we are going to track the development of this feature request in this other issue: #171

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants