Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper model definition of app configuration #196

Open
arnauorriols opened this issue Nov 16, 2023 · 0 comments
Open

Proper model definition of app configuration #196

arnauorriols opened this issue Nov 16, 2023 · 0 comments

Comments

@arnauorriols
Copy link
Member

My understanding is that it reads a config file and merges it to Args. But I'm a little bit concerned with this approach because Args is just a parsed result of std's parse function, which doesn't have any domain knowledge of individual applications.

What I'd like to propose is to define a new class/object that stores all configurable values (which I'll call Config) and construct Config from the config file, command line args, and even env vars, then we'll be able to use the Config instance throughout the process.

Originally posted by @magurotuna in #193 (review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant