Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signals in unmount hook are breaking partial navigation silently #2801

Open
darkship opened this issue Dec 26, 2024 · 1 comment
Open

signals in unmount hook are breaking partial navigation silently #2801

darkship opened this issue Dec 26, 2024 · 1 comment

Comments

@darkship
Copy link

Hello,
When I navigate between 2 pages using partials, if there is an unmount hook in an island it will break the app until you reload.

Unmount hook (see Counter.tsx)

    useEffect(()=>{
        return ()=> {
            console.log(props.count.value)
        }
    },[])

Repo: https://github.com/darkship/fresh-bug-signal-unmount

signal_bug_unmount-2024-12-26_19.45.29.mp4
@MrDwarf7
Copy link

This seems quite similar to what I've reported over on #2797 as well - I noticed it first on the webiste and this seems quite similar.
Was having a look through the library code and I'm able to pinpoint it but not sure how to resolve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants