Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@std/webgpu/texture_with_data.ts has flaky test #6429

Open
timreichen opened this issue Feb 19, 2025 · 3 comments
Open

@std/webgpu/texture_with_data.ts has flaky test #6429

timreichen opened this issue Feb 19, 2025 · 3 comments
Assignees
Labels
bug Something isn't working needs triage

Comments

@timreichen
Copy link
Contributor

https://github.com/denoland/std/actions/runs/13420418226/job/37491446085?pr=6408

 ERRORS 

createTextureWithData() => ./webgpu/texture_with_data_test.ts:7:6
error: TypeError: Failed to execute 'call' on 'GPUDevice': 'format' of 'GPUTextureDescriptor' (Argument 0) can not be converted to a enum
  const texture = device.createTexture(descriptor);
                         ^
    at createTextureWithData (file:///D:/a/std/std/webgpu/texture_with_data.ts:130:26)
    at fn (file:///D:/a/std/std/webgpu/texture_with_data_test.ts:16:5)

 FAILURES 

createTextureWithData() => ./webgpu/texture_with_data_test.ts:7:6

FAILED | 4142 passed (2719 steps) | 1 failed | 25 ignored (2m17s)

error: Test failed
Error: Process completed with exit code 1.
@timreichen timreichen added bug Something isn't working needs triage labels Feb 19, 2025
@crowlKats crowlKats self-assigned this Feb 19, 2025
@crowlKats
Copy link
Member

tried locally, however cannot reproduce. also, this being a flake makes no sense...

@timreichen
Copy link
Contributor Author

tried locally, however cannot reproduce. also, this being a flake makes no sense...

No idea why this happens, but I've seen this error multiple times on different @std PRs. Maybe it is a bug in deno's GPUDevice or GPUTextureDescriptor implementation?

@kt3k
Copy link
Member

kt3k commented Feb 21, 2025

The error message seems created in this line? https://github.com/denoland/deno_core/blob/7cbc5ae35c279972d46e5552b7a5978860df611e/core/webidl.rs#L96

Is it possible that CI machine's state affects this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage
Projects
None yet
Development

No branches or pull requests

3 participants