Bug: VAMC editors can create detail pages under Work with us

[jilladams]

Description or Additional Context

Follow on to #16959

VAMC detail pages under work with us can now be saved. However: new Detail Pages can also be created under Work with us, which is counter to VAMC governance.

Rules for Menu behavior are defined in VAMC Menu Custom Access config. Any code changes should work in conjunction with the config.

History and Other connections

• Bug surfaced in Slack 1/18/23
• Investigation determined where the bug was introduced
• PR that introduced it and the issues Alt Text validation #15785 Create tests for alt text validation #15783
• PR for temporary fix and issue VAMC editors can't save detail pages under Work with us #16959
• Slack thread about the temporary fix and transfer of ownership for the real fix to Facilities team
• Slack thread on Facilities handling.

There are essentially three problems that need to be solved:

1. Due to an unclosed reference in a foreach (see first pink warning), the last validator in the list of validations for every node save (not limited to detail pages) was always running twice. This is not performant and can cause confusion.
2. The clientside jquery validation contrib module was being too aggressive and interpreting disabled select list item as empty even though they had a value. This is the direct cause of editors not being able to save some detail pages. I created an upstream drupal issue here.
3. The temporary fix is a hard coded solution that bypasses the intentional configuration about what menu can be changed and which ones can have children. It short circuits much of the handling in the Facility Team's MenuReductionService

Acceptance Criteria

• VAMC Menu Custom Access config rules are respected with regard to create, edit, archive rules for VAMC Detail Pages
• Behavior of menu logic reproduces what we had in place before alt text validation was added. A current source for testing is in this tugboat
  

[jilladams]

https://dsva.slack.com/archives/C0FQSS30V/p1706303824010159 -

The fix for the menu locking is on prod now. It looks like we had ~20 details pages updated in the window between today and yesterday's deploy. I am checking each of them now to make sure they did not drift out of their intended location.
I looked at all 21 of the detail pages that were editied between yesterday's deploy and today's None of them moved from where they are supposed to be. We are all clear.

Closing based on this verification.