Audit: Facilities Drupal content types for Phone number fields implementation

[jilladams]

User Story or Problem Statement

Description or Additional Context

Question we are trying to answer: Which phone numbers fields use Telephone number field alone, vs. Telephone field with a separate extension input.

Acceptance Criteria

• Document where phone numbers are used and which type
• Make notes of the help text associated with those fields
• Link to notes on Update phone numbers in Facilities products to use component #16148

[davidmpickett]

@jilladams Adding to Sprint 1, but noting it was an injection

[laflannery]

Document with audit and summary:
Facilities Phone Number field summary.docx

[laflannery]

@jilladams After doing this and closing it, I'm unsure if there is a clear next step. Would I go through this at a UX sync? Does the ticket I links to in the last AC just pick it up as the next step? I just want to make sure the follow through is taken care of

[jilladams]

I think the right next step is some Product work to:

• Review your notes
• Review the state of existing other tickets and reduce overall confusion
• Define a logical next step of work.

I think you and I (and @davidmpickett if he's interested) could have a working meeting to look at a few things and get a lot of clarity. #16148 is planned for next sprint. I'll look for time early in the week for us to chat.

[jilladams]

Doc is uploaded to Sharepoint here (FYI I moved this from the Sitewide folder to the Facilities folder because it's a Facilities specific audit)

Super epic for phone number problems now exists: #17854. New tickets can go there.

[jilladams]

Findings

Laura's audit found 3 phone number fields in Drupal that need to be split with a separate extension field ( using the Phone number paragraph type field). We will have 7 tickets: a Drupal and a FE ticket for each of these (that will live in #17854). :

1. Drupal & FE: Staff profile: number
2. Drupal & FE: Billing & Insurance number
3. Drupal & FE: VAMC Facility mental health number
   • This ticket for Drupal should have an AC to verify the migration push with Lighthouse before merging.
4. The phone paragraph type validation needs to add validation to the extension field to prevent text entry (which breaks the FE component). -- Should be a priority now if we can, to prevent Editor entry that could break FE components.
   • This ticket should include an AC to add validation error text / character counter to explain the 12 char max.

The 6 other tickets besides validation are not urgent. But: an Editor can break the FE component until we get them done. Meantime: if that happens, we can mitigate it by fixing the Editor entry issues.

Guidance:

• We should document guidance for phone number implementations to note that we want to use the phone paragraph type, instead of telephone field, moving forward. This will be true for Facilities, but we also think this should be guidance the CMS team adopts broadly (and eventually try to deprecate the Telephone field type).
  • Previously for character counters: Dave wrote up guidance and sent to the CMS team for considerations about how they integrate into their docs long term.
  • In this case: Laura will write up that documentation, and provide it to Marisa via an existing touchpoint. (Amanda K is aware we will probably want to do this.)

Optional things to consider separately / later:

• Separately ticketing breaking up phone number fields that aren't currently editable to align them with the paragraph / separate extension field. Not urgent. Laura will sub a backlog ticket for this.
• 12 char max doesn't allow for int'l #s, but that's not a problem we need to solve today. (Laura spot checked Guam, and they seem to be using 1-800 #s.)
• SPIKE: CMS: Phone number validation and guidance #15691 is an existing spike, where we can add some helpful notes.

[davidmpickett]

FYI Here's the Character Counter guidance issue:
#16659

[jilladams]

@laflannery when you talk to Marisa about the proposed guidance here, could you two take a look at #15691 and note there whether you feel like that ticket is still necessary? (Relevant bc right now it technically blocks #16906. If we decide the provided guidance is Good Enough For Now TM, then #16906 might become unblocked.)

[laflannery]

@jilladams I definitely can - is there a deadline or anything for this now that there is a VBA connection? I.E, we want to find out if this is unblocked by X date?

[jilladams]

@laflannery 16906 isn't considered launch blocking (according to launch plan #16268), so not on fire, just something we'd like to get to if/when possible for Pilot.