Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BLOCKED] [Analytics] [Landing pages] Custom GA events removal & web component upgrades #18506

Open
4 tasks
randimays opened this issue Jul 12, 2024 · 1 comment
Labels
Blocked Issues that are blocked on factors other than blocking issues. ghp-backlog Needs refining Issue status Public Websites Scrum team in the Sitewide crew sitewide Telephone field(s) VA.gov frontend CMS team practice area

Comments

@randimays
Copy link
Contributor

randimays commented Jul 12, 2024

Status

[2024-08-19] [Fran] Info from Randi: This ticket should be taken with similar caution as #18502. In #18502 (comment), @laflannery explained that we have some outstanding issues in order to be able to reliably convert telephone numbers to the web component.

Before we can pick up and work this ticket, we need to carefully consider exactly how each of the links are constructed and our technical approach to converting them to web components, if possible.
[2024-08-14] [Fran] Not urgent; no dupe events.
[2024-07-15] [Fran] Noting that this needs to be refined by the team in our next prefinement.

Description

The va-link web component's analytics now include link destination, and va-link-action has been released to the component library. We can now use baked-in analytics on the Resources & Support detail pages where the default contact is used.

Example pages:

Engineering notes

Code where these links exist:

User story

AS A PO/PM managing Public Websites products & features
I WANT to (where appropriate) adopt the va-link or va-link-action component, its baked-in analytics, and remove the custom GA events
SO THAT extraneous code is removed and only the events needed will be triggered.

Acceptance criteria

  • Elements: all phone numbers in the "Call us" section (sidebar)
    • convert to va-telephone component
    • remove custom events
  • a11y review
@randimays randimays added Needs refining Issue status Public Websites Scrum team in the Sitewide crew sitewide VA.gov frontend CMS team practice area labels Jul 12, 2024
@randimays
Copy link
Contributor Author

This ticket should be taken with similar caution as #18502. In a comment there, @laflannery explained that we have some outstanding issues in order to be able to reliably convert telephone numbers to the web component.

Before we can pick up and work this ticket, we need to carefully consider exactly how each of the links are constructed and our technical approach to converting them to web components, if possible.

@chriskim2311 chriskim2311 added Needs refining Issue status and removed Needs refining Issue status labels Jul 15, 2024
@FranECross FranECross added the Blocked Issues that are blocked on factors other than blocking issues. label Aug 14, 2024
@FranECross FranECross changed the title [Analytics] [Landing pages] Custom GA events removal & web component upgrades [BLOCKED] [Analytics] [Landing pages] Custom GA events removal & web component upgrades Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked Issues that are blocked on factors other than blocking issues. ghp-backlog Needs refining Issue status Public Websites Scrum team in the Sitewide crew sitewide Telephone field(s) VA.gov frontend CMS team practice area
Projects
None yet
Development

No branches or pull requests

4 participants