Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BLOCKED] [Events] Hide past events on Event Detail pages so they no longer display #9474

Open
3 of 13 tasks
jilladams opened this issue Jun 15, 2022 · 6 comments
Open
3 of 13 tasks
Labels
Accelerated Publishing Blocked Issues that are blocked on factors other than blocking issues. Events product maintained by Public Websites team ghp-backlog points-2 Public Websites Scrum team in the Sitewide crew sitewide VA.gov frontend CMS team practice area

Comments

@jilladams
Copy link
Contributor

jilladams commented Jun 15, 2022

[2024-08-07] Blocked on AP shipping Events to production, unless it becomes a fire drill.

Describe

Recurring events detail pages, "View other times for this event" panel shows all occurrences, including those in the past, with active "Add to calendar" links.

Per Michelle (7/2024) we should hide all past events from the FE, so that the Veteran/all users only see current/future events. The Government requirement to retain past events doesn't mean we need to display them; it means we need to keep them in the DB/Drupal/available if we need to report on them.

To Reproduce

Steps to reproduce the behavior:

  1. Go to a recurring event with recurrences past and upcoming, e.g. https://staging.va.gov/minneapolis-health-care/events/42754/
  2. Click on View other times for this event
  3. See past dates

Expected behavior

All past events are hidden; only current/future events display
https://dsva.slack.com/archives/C52CL1PKQ/p1658422431625569?thread_ts=1658408251.943929&cid=C52CL1PKQ

Acceptance criteria

  • All past events are hidden and no longer display

Screenshots

Current behavior
Screen Shot 2022-06-15 at 10 53 26 AM

Desired behavior
All past events are hidden
image (2)

Labels

(You can delete this section once it's complete)

  • Issue type (red) (defaults to "Defect")
  • CMS subsystem (green)
  • CMS practice area (blue)
  • CMS workstream (orange) (not needed for bug tickets)
  • CMS-supported product (black)

CMS Team

Please check the team(s) that will do this work.

  • Program
  • Platform CMS Team
  • Sitewide Crew
  • ⭐️ Sitewide CMS
  • ⭐️ Public Websites
  • ⭐️ Facilities
  • ⭐️ User support
@jilladams jilladams added Needs refining Issue status Epic Issue type labels Jun 15, 2022
@jilladams jilladams changed the title Event detail page w/ recurrence: When" Event detail page w/ recurrence: "When" always shows the first date in the recurrence series Jun 15, 2022
@jilladams jilladams changed the title Event detail page w/ recurrence: "When" always shows the first date in the recurrence series Event detail page w/ recurrence: "View other times for this event" panel shows occurrences in the past Jun 15, 2022
@jilladams jilladams added VA.gov frontend CMS team practice area Public Websites Scrum team in the Sitewide crew and removed Epic Issue type labels Jun 15, 2022
@jilladams
Copy link
Contributor Author

jilladams commented Jul 6, 2022

Don't want to add past events to calendar.
Need to validate expected behavior with Veteran research before we take action.
Would want to fold this into a future filter iteration.

@jilladams jilladams changed the title Event detail page w/ recurrence: "View other times for this event" panel shows occurrences in the past Event detail page w/ recurrence: "View other times for this event" panel shows occurrences in the past with active Add to calendar link Jul 22, 2022
@davidmpickett davidmpickett added the Events product maintained by Public Websites team label Apr 27, 2023
@FranECross FranECross removed the Needs refining Issue status label Apr 23, 2024
@randimays randimays self-assigned this Apr 24, 2024
@randimays
Copy link
Contributor

Update here: this one is also blocked because we can't use va-icon in content-build yet for this:
Screenshot 2024-04-25 at 11 24 39 AM

Ray said they are nearly finished fixing the issue and are testing today.

@randimays randimays added the Blocked Issues that are blocked on factors other than blocking issues. label Apr 25, 2024
@FranECross FranECross removed the Blocked Issues that are blocked on factors other than blocking issues. label May 7, 2024
@jilladams
Copy link
Contributor Author

@FranECross do you recall what PM action was needed here?

@FranECross
Copy link

FranECross commented May 14, 2024

@jilladams It was to check with Ray to see if the testing was successful. Let me find my Slack message asking and I'll ping them again. I don't believe I got a response. I was thinking of a different ticket. I think I was going to create a UX ticket for Jordan, and then spin this one back up after she provided direction. I'll look follow up on this.

@FranECross FranECross changed the title Event detail page w/ recurrence: "View other times for this event" panel shows occurrences in the past with active Add to calendar link [Events] Event detail page w/ recurrence: "View other times for this event" panel shows occurrences in the past with active Add to calendar link Jul 29, 2024
@FranECross FranECross changed the title [Events] Event detail page w/ recurrence: "View other times for this event" panel shows occurrences in the past with active Add to calendar link [Events] Remove past events from Event Detail pages Jul 29, 2024
@FranECross FranECross changed the title [Events] Remove past events from Event Detail pages [Events] Hide past events on Event Detail pages so they no longer display Jul 29, 2024
@jilladams
Copy link
Contributor Author

In cross-team sync today, AP requested that unless an issue is burning, they would prefer to push it out by ~1 month. AP is hoping to move Events to production in 2 sprints. Michelle was present and signed off on pulling this out of our sprint with that in mind. Hopefully when we come back to it, we can make this change in AP templates rather than in content-build.

Removing from sprint. FYI @randimays @FranECross

@aklausmeier
Copy link

@bethpottsVADEPO FYA

@FranECross FranECross added the Blocked Issues that are blocked on factors other than blocking issues. label Sep 10, 2024
@FranECross FranECross changed the title [Events] Hide past events on Event Detail pages so they no longer display [BLOCKED] [Events] Hide past events on Event Detail pages so they no longer display Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accelerated Publishing Blocked Issues that are blocked on factors other than blocking issues. Events product maintained by Public Websites team ghp-backlog points-2 Public Websites Scrum team in the Sitewide crew sitewide VA.gov frontend CMS team practice area
Projects
None yet
Development

No branches or pull requests

5 participants