prefer SafeVersions property before considering other version restrictions
#11312
+172
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettfo
force-pushed
the
dev/brettfo/nuget-update-analysis-limits
branch
from
1687348 to
1b7afad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a
safe_versionis listed in a vulnerability, prefer that version to anything else. If no safe versions are explicitly listed, fall back to previous behavior.The lambda version filter was rewritten to make it easier to read and debug. At the start we check for the
SafeVersionsproperty and the remainder of the lambda is the exact same old code, just with each condition extracted and explicitly named. This also makes debugging easier because there are several places to set a breakpoint.The run worker was also updated to generate the correct
DependencyInfoobject from the job file.Fixes #11311.