Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False Positive: Ensures DT and DD elements are contained by a DL (reopen 1265) #4128

Closed
1 task done
jplejacq-quoininc-com opened this issue Aug 12, 2023 · 4 comments
Closed
1 task done
Labels
ungroomed Ticket needs a maintainer to prioritize and label

Comments

@jplejacq-quoininc-com
Copy link

Product

axe-core

Product Version

4.60.1

Latest Version

  • I have tested the issue with the latest version of the product

Issue Description

Expectation

This is reopening an earlier issue with the same title
#1265

A test site to see this is:

https://salus-cm.care/

@jplejacq-quoininc-com jplejacq-quoininc-com added the ungroomed Ticket needs a maintainer to prioritize and label label Aug 12, 2023
@straker
Copy link
Contributor

straker commented Aug 14, 2023

Thanks for the issue. I believe the issue is that each of the dl and wrapping div elements each use role=list and role=listitem respectively. This causes the definition list to be treated as a list so the dt element is not contained with a definition list. If you remove the roles it should work.

@jplejacq-quoininc-com
Copy link
Author

jplejacq-quoininc-com commented Aug 14, 2023 via email

@straker
Copy link
Contributor

straker commented Aug 14, 2023

The problem is that a dt and dd element can only be used within a roleless dl element and contained by a roleless div element. What was the issue that you were trying to fix by adding the roles?

@straker
Copy link
Contributor

straker commented Nov 17, 2023

Closing due to lack of activity. Please feel free to reopen if you can provide more information.

@straker straker closed this as completed Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ungroomed Ticket needs a maintainer to prioritize and label
Projects
None yet
Development

No branches or pull requests

2 participants