Fails to generate types with a library that defines enums

[stwiname]

When I attempt to generate types I am getting this error Error occured: Unknown type: ALib.BOOL

I have attached a minimal example: Archive.zip
To repro: yarn && yarn build

The error seems to be the same as #125 but is still happening

[quezak]

Preliminary research shows that the ABI for the other function is different for a library:

// ...
      "inputs": [
        {
          "internalType": "enum ALib.BOOL",
          "name": "b",
          "type": "ALib.BOOL"
        }

While if I just change interface ALib to contract ALib, the type of the argument is plain uint8:

// ...
      "inputs": [
        {
          "internalType": "enum ALib.BOOL",
          "name": "b",
          "type": "uint8"
        }

I'll check if that's only when compiling with Truffle (personally I'm using Waffle :) )

[quezak]

Confirmed, the situation is the same. We'll need to see why the ABI differs between these two cases and how we can handle that in the generation step -- it will probably affect all targets.

Btw, sorry @stwiname for the delayed response, and thanks for the full repro.

[SilentCicero]

I'm stuck on this as well.

[quezak]

@SilentCicero what solc version are you using? I'm wondering if it's still the same in v0.7.0

[SilentCicero]

6.8 currently with buidler

…

On Wed, Sep 16, 2020 at 4:08 AM Artur Kozak ***@***.***> wrote: @SilentCicero <https://github.com/SilentCicero> what solc version are you using? I'm wondering if it's still the same in v0.7.0 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#216 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACK2CXSYVBNRMW4YE6XCHNTSGBXANANCNFSM4KWMR7RQ> .

[krzkaczor]

@stwiname @SilentCicero Can someone prepare minimal repro for this?

[quezak]

@krzkaczor OP already contains a minimal repro :D when I checked it in March it was correct (ie. was bugged as described above)

[krzkaczor]

Sorry I missed it 😆 I will work on this later today

[krzkaczor]

This should be fixed now! Relased as [email protected]

[SilentCicero]

Sweet, thanks all!

…

On Mon, Oct 5, 2020 at 11:39 AM Kris Kaczor ***@***.***> wrote: This should be fixed now! Relased as ***@***.*** — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#216 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACK2CXWDB54AYJJFPWNHHZLSJHSDZANCNFSM4KWMR7RQ> .

[cameel]

This is not the only inconsistency in the library ABI. This comes mostly from the fact that selectors for library functions are computed differently than for contract functions, but still, it's a bit of a mess. There's already an issue for it in Solidity repo and the discussion on how to handle it is ongoing. Since you're clearly affected by this, any feedback from your side would be appreciated.