Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add init. impl. of NumberBaseConversion #72

Merged
merged 9 commits into from
Jul 18, 2022
Merged

Conversation

7sne
Copy link
Collaborator

@7sne 7sne commented Jul 14, 2022

Closes #61

@vercel
Copy link

vercel bot commented Jul 14, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
tools ✅ Ready (Inspect) Visit Preview Jul 18, 2022 at 10:39AM (UTC)

@7sne 7sne marked this pull request as ready for review July 15, 2022 09:17
@7sne 7sne requested a review from LogvinovLeon July 15, 2022 09:17
@LogvinovLeon
Copy link
Contributor

There is a bug with the octal numbers. When you start typing decimal—it converts and puts no 0 prefix at the beginning. But when you put an octal number without a prefix—you get an error. I think it should either accept one of those formats or both, but accepting one on read and the other on write seems weird

@7sne 7sne merged commit 6e751a5 into main Jul 18, 2022
@7sne 7sne deleted the Number-base-conversion-tool branch July 18, 2022 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Number base converter
2 participants